Ticket #2273 (closed defect: Fixed)

Opened 13 months ago

Last modified 8 weeks ago

zenmigrate GraphDefinitionsAndFriends acquisition sometimes breaks

Reported by: chris Owned by: jstevens
Priority: 3 - Medium Milestone: zenoss-2.2
Component: ZenRRD Version: 2.1.0
Keywords: zenoss-2.1.1-patched Cc:
Community Patch Attached: Deployed @ Customer:
Installer: Maintenance Target:
Specific ZenPack: Maintenance Status:
Documentation Note?: Not required Regression:

Description

When running zenmigrate I came across the following error:
AttributeError: stacked

This comes as a result of the code in graphDefinitionsAndFriends.py:

                oldGraph = getattr(template.graphs, graphDef.id, None)
                if not oldGraph:
                    continue
                for gp in graphDef.graphPoints():
                    gp.stacked = oldGraph.stacked

Jason says that we should not use getattr in this case but instead should use _getOb(). He also suggests this fix is applied to the 2.1.1 release.

Change History

Changed 13 months ago by chris

(In [7343]) refs #2273: use acquisition to obtain the graph definition id

Changed 13 months ago by jstevens

  • owner changed from ecn to jstevens

Changed 13 months ago by jstevens

  • keywords zenoss-2.1.1-proposed added; zenoss-2.1.1 removed
  • status changed from new to closed
  • resolution set to fixed

Changed 13 months ago by jstevens

  • keywords zenoss-2.1.1-approved added; zenoss-2.1.1-proposed removed

Approved for 2.1.1, but migrate script not reviewed yet

Changed 13 months ago by ecn

  • keywords zenoss-2.1.1-accepted added; zenoss-2.1.1-approved removed

Changed 13 months ago by marc

(In [7472]) Patching r7343 to 2.1.x branch

Changed 13 months ago by marc

  • keywords zenoss-2.1.1-patched added; zenoss-2.1.1-accepted removed

Changed 8 weeks ago by bbibeault

  • documentation set to Not required
  • reviewed set to 1
Note: See TracTickets for help on using tickets.