Three unit tests in testDevice.TestDevice fail

[ian]

The problem is in checkDeviceExists, which should only do findDevice(ip) if ip exists. Since ip is empty, it returns the first device in the index.

======================================================================
ERROR: testManage_createDeviceDup (tests.testDevice.TestDevice)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "Users/ian/zenoss/lib/python/Testing/ZopeTestCase/profiler.py", line 98, in __call__
  File "/Users/ian/src/zenoss/trunk/Products/ZenModel/tests/testDevice.py", line 56, in testManage_createDeviceDup
    dev = manage_createDevice(self.dmd, 'mydevice', '/', manageIp='1.1.1.1')
  File "/Users/ian/zenoss/Products/ZenModel/Device.py", line 102, in manage_createDevice
    checkDeviceExists(context, deviceName, manageIp, performanceMonitor)
  File "/Users/ian/zenoss/Products/ZenModel/Device.py", line 81, in checkDeviceExists
    raise DeviceExistsError("Manage IP %s already exists" % deviceName,ip)
DeviceExistsError: Manage IP mydevice already exists

----------------------------------------------------------------------
Ran 42 tests in 227.024s

FAILED (errors=2)

[ian]

Proposed fix

[ian]

(In [9761]) * Fixes #3505. Approved by ECN.

[ian]

(In [9787]) * Refs #3505: Cleaned up previous code a bit.

[ian]

(In [9788]) * Refs #3505: Backporting 9761 9787 to the zenoss-2.2.x branch

[ian]

(In [9789]) * Refs #3505: Stupid typo, I am dumb

[ian]

(In [9790]) * Refs #3505: Backporting 9789 into the zenoss-2.2.x branch