If network doesn't exist Zenoss generates a Traceback while it is Discovering Devices

[arivera]

Description

This is not a high priority scenario. If user adds a wrong Network name. Zenoss adds the new network but it doesn't validate if it exists or not. Later, it crashes while it is discovering devices.
In this case, it should not crash and a clear message should be shown to the user.

• Zenoss Version: RPM Build 170
• Operating System(s): Cent5 64 bits

Steps to Reproduce

1. Navigate to Networks
2. Select Table Menu->Add Network
3. Add a network name that doesn't exist. For instance, 10.175.233.0/255. Press Ok
4. Select Table Menu->Discovering Devices

Results

It generates a traceback during the process and it also show a message that is not related to the problem.

it shows the following error:

Traceback (most recent call last): 
File "/opt/zenoss/lib/python/ZPublisher/Publish.py", line 114, in publish
 request, bind=1) 
File "/opt/zenoss/lib/python/ZPublisher/mapply.py", line 88, in mapply
 if debug is not None: return debug(object,args,context) 
File "/opt/zenoss/lib/python/ZPublisher/Publish.py", line 40, in call_object 
result=apply(object,args) # Type s to step into published object. 
File "/opt/zenoss/Products/ZenModel/IpNetwork.py", line 467, in discoverDevices
 cmd = ["zendisc", "run", "--weblog", "--net", organizer.id] AttributeError: 'NoneType' object has no attribute 'id' 

Also, it displays this message during the process. It is not clear and it doesn't help to figure what is the problem and how to solve it.

2008-12-04 17:24:28	ERROR  	Zope.SiteErrorLog	http://test-cent5-64-2.zenoss.loc:8080/zport/dmd/Networks/discoverDevices

Expected Results

It should show a better error message.

Impact

Usability

[kkearney]

(In [11363]) * Refs #4112: add sanity check for organizer.

[kkearney]

(In [11364]) * Fixes #4112: add sanity check for organizer. Reviewed by ecn